Utils.waitUntilReady should record the stack trace of the caller before rethrowing an exception #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
rohanKanojia
added
the
changelog missing
rohanKanojia
reviewed
Oct 7, 2019
| @@ -130,7 +130,9 @@ public static boolean waitUntilReady(BlockingQueue<Object> queue, long amount, T | |||
| if (obj instanceof Boolean) { | |||
| return (Boolean) obj; | |||
| } else if (obj instanceof Throwable) { | |||
| throw (Throwable) obj; | |||
| Throwable t = (Throwable) obj; | |||
| t.addSuppressed(new Throwable("waiting here")); | |||
There was a problem hiding this comment.
Could we be more expressive in the message inside throwable? Or does this message has not any significance?
rohanKanojia
approved these changes
Oct 7, 2019
…re rethrowing an exception.
rohanKanojia
force-pushed
the
Utils.waitUntilReady
branch
from
971a57d to
4062bd3
Compare
rohanKanojia
removed
the
changelog missing
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a situation where one method in my code called a second, which called a third, which called
Watchable.watch, and I thinkwatchthrew up an exception (in this case due to an RBAC mistake) which was caught ultimately in my first method (according to the method name recorded byjava.util.logging)…but it was hard to tell for sure since the stack trace includingwatchwas nowhere to be seen:Poking around, my guess is that the problem is that
Utils.waitUntilReadyis taking this exception thrown and caught in some thread pool and rethrowing it to its caller. Somehow the caller’s stack trace needs to be included.(Another idiom is to wrap the original exception in a new exception using
cause, but that forces you to pick a type for the wrapper; usingaddSuppressedavoids that issue.)I had hoped to test this change against the original reproduced problem; unfortunately I did not manage to compile this project, getting seemingly different puzzling errors from Maven or javac each time, like
or
or